Fix unittest warnings #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this patch, it is possible to call `conn.close()` method multiple times. Part of #250
assertRaisesRegexp and assertEquals were renamed in version 3.2 [1]. 1. https://docs.python.org/3/library/unittest.html#deprecated-aliases Part of #250
Fix several ResourceWarning messages related to test Tarantool server methods not cleaning up sockets. Part of #250
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-250-unittest-warnings
branch
from
9a9b479 to
c6e59f3
Compare
This was referenced Oct 24, 2022
Merged
|
|
DBAPI2 compliance tests are not implemented here but inherited from external module [1]. Two tests from this module open a connection and forget to close it. The issue [2] had been fixed and PR had been merged, but there is no tagged release yet. 1. https://pypi.org/project/dbapi-compliance/ 2. baztian/dbapi-compliance#5 Part of #250
There are several ConnectionPool tests that stop some pool instances and verify that everything works fine even for semi-functional cluster. Different network and cluster state warning are issued in this case. They are expected and not informative, thus it is better to filter them in final output. Closes #250
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-250-unittest-warnings
branch
from
cb12b7b to
7baa481
Compare
Install package from master commit for tests |
DifferentialOrange
deleted the
DifferentialOrange/gh-250-unittest-warnings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api: make connection close idempotent
After this patch, it is possible to call
conn.close()method multipletimes.
Part of #250
test: replace deprecated methods
assertRaisesRegexp and assertEquals were renamed in version 3.2 [1].
Part of #250
test: fix server resource warnings
Fix several ResourceWarning messages related to test Tarantool server
methods not cleaning up sockets.
Part of #250
test: fix unix socket test resource warnings
hasattr check actually has no effect for unittest runtime-added fields,
so both server and connection for unix socket test weren't closed after
run.
Part of #250
test: fix test connection resource warnings
Close all connection opened in tests even in case of failed asserts.
Part of #250
test: fix dbapi test connection resource warnings
DBAPI2 compliance tests are not implemented here but inherited from
external module [1]. Two tests from this module open a connection and
forget to close it. The issue [2] had been fixed and PR had been merged,
but there is no tagged release yet.
Part of #250
test: filter warnings for disabled instances
There are several ConnectionPool tests that stop some pool instances
and verify that everything works fine even for semi-functional cluster.
Different network and cluster state warning are issued in this case.
They are expected and not informative, thus it is better to filter them
in final output.
Closes #250